Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): ensure OsxNotarizeOptions definition contains credentials #1167

Merged
merged 1 commit into from Jul 12, 2020

Conversation

malept
Copy link
Member

@malept malept commented Jul 10, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1162.

@malept malept requested a review from a team July 10, 2020 15:55
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #1167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          698       698           
=========================================
  Hits           698       698           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c3e96...dd97f7a. Read the comment docs.

@malept
Copy link
Member Author

malept commented Jul 10, 2020

@ffflorian can you test this fix?

Copy link

@ffflorian ffflorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@malept malept merged commit 19ec0b0 into master Jul 12, 2020
@malept malept deleted the malept/fix/tsd/notarize-options branch July 12, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid OsxNotarizeOptions type
3 participants