Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): allow checking official builds against prerelease versions #1191

Merged
merged 1 commit into from Nov 16, 2020

Conversation

PalmerAL
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1190

The behavior exhibited by semver in that issue is apparently intended behavior, but I don't think it makes much sense in this context, so I've set the option to disable it, which allows ARM64 builds to work as intended.

@welcome
Copy link

welcome bot commented Nov 15, 2020

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@malept malept changed the title Support ARM64 builds for prerelease versions fix(targets): allow checking prerelease versions Nov 16, 2020
@malept malept changed the title fix(targets): allow checking prerelease versions fix(targets): allow checking official builds against prerelease versions Nov 16, 2020
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #1191 (3a65e45) into master (7bc13c4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          698       698           
=========================================
  Hits           698       698           
Impacted Files Coverage Δ
src/targets.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc13c4...3a65e45. Read the comment docs.

@malept malept merged commit 5210c37 into electron:master Nov 16, 2020
@welcome
Copy link

welcome bot commented Nov 16, 2020

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building for Linux arm64 with a beta version of Electron doesn't work
2 participants