Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bundled app validation to ensure that package.json and main entry point exist #1257

Merged
merged 2 commits into from Jul 12, 2021

Conversation

malept
Copy link
Member

@malept malept commented Jul 8, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

More than once in the Discord server I've had to help someone debug their app bundling, and it turned out that their ignore settings ignored either their package.json file or their main entry point script (e.g., main.js). This PR adds a validation check before it generates an ASAR to make sure that both exist.

@malept malept requested a review from a team July 8, 2021 16:00
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1257 (c447a69) into master (a82345b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          698       715   +17     
=========================================
+ Hits           698       715   +17     
Impacted Files Coverage Δ
src/common.js 100.00% <100.00%> (ø)
src/platform.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82345b...c447a69. Read the comment docs.

@malept malept merged commit 452d9d6 into master Jul 12, 2021
@malept malept deleted the malept/feat/validate-bundled-app branch July 12, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants