Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to rcedit@^3.0.1 #1260

Merged
merged 4 commits into from Jul 16, 2021
Merged

feat: upgrade to rcedit@^3.0.1 #1260

merged 4 commits into from Jul 16, 2021

Conversation

malept
Copy link
Member

@malept malept commented Jul 16, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This upgrade adds two features:

  • Support for running rcedit on darwin/arm64
  • Support for running rcedit on WSL without Wine installed

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1260 (980982b) into master (c30e584) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1260   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          715       716    +1     
=========================================
+ Hits           715       716    +1     
Impacted Files Coverage Δ
src/win32.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30e584...980982b. Read the comment docs.

@malept malept merged commit 569c6bd into master Jul 16, 2021
@malept malept deleted the malept/chore/rcedit-3 branch July 16, 2021 22:58
ChALkeR referenced this pull request in ExodusMovement/electron-packager Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant