Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make canary run --arch=universal on macOS #1539

Merged
merged 5 commits into from Jul 31, 2023
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jul 28, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summary

Our electron-nightly canary job runs the latest nightly version of Electron against the main branch of Electron Packager.

This job has been busted for a while, and it seems because --arch=all does not work on macOS ever since we. This is a separate issue, but for now, let's just create a single --arch=universal job so that we can unblock the canary.

Testing

See c7a3088 for that job running on this PR.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1539 (aa10ea9) into main (5ee6d73) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1539   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          15       15           
  Lines         793      793           
=======================================
  Hits          758      758           
  Misses         35       35           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erickzhao erickzhao force-pushed the erickzhao-patch-2 branch 2 times, most recently from 347eac5 to 4c6c42f Compare July 28, 2023 22:27
@erickzhao erickzhao marked this pull request as ready for review July 31, 2023 18:16
@erickzhao erickzhao requested a review from a team as a code owner July 31, 2023 18:16
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just one nit

.github/workflows/canary.yml Outdated Show resolved Hide resolved
@erickzhao erickzhao merged commit 6430d3f into main Jul 31, 2023
5 checks passed
@erickzhao erickzhao deleted the erickzhao-patch-2 branch July 31, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants