Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove broken default option #1658

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

erikian
Copy link
Member

@erikian erikian commented Jan 12, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This default value has been broken for a while, as @electron/get expects the rejectUnauthorized property inside the downloadOptions object, not as a top-level option. This PR is just updating the docs to reflect the current behavior.

@erikian erikian requested a review from a team as a code owner January 12, 2024 22:57
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55eebc7) 91.80% compared to head (8f14277) 91.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1658   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          16       16           
  Lines         854      854           
  Branches      167      167           
=======================================
  Hits          784      784           
  Misses         52       52           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erikian erikian merged commit 10474b0 into main Jan 12, 2024
5 checks passed
@erikian erikian deleted the chore/remove-broken-option branch January 12, 2024 23:31
Copy link

🎉 This PR is included in version 18.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants