[win32] Ensure product version is set on the executable #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a test for this behavior.
malept
added
the
build-target:windows
|
@p-bakker could you test this fix to see if it fixes your specific case? (It's still a good change to merge, regardless.) |
|
Tested it: at first seemed to have no effect at all. Debugged a bit and I figured out I wasn't updating the right electron-packager copy (duh...) So, after I corrected that mistake, the FileVersion started working, but not the ProductVersion. Debugged that a bit more and found the issue: rcedit doesn't seem to support setting the ProductVersion to value 1. If I try setting it to 0.9 or 1.1 or any other value, the ProductVersion is properly set, if I use 1 (or 1.0) the ProductVersion is not set. So, conclusion: the fixes for FileVersion/ProductVersion work, but there is another issue in rcedit |
malept
added a commit
that referenced
this pull request
Oct 26, 2015
[win32] Ensure product version is set on the executable
This was referenced Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a copy/paste solution from #143. Includes a test.
Attempts to fix #172.