Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Binary in OSX (CFBundleExecutable) #195 #244

Closed
wants to merge 1 commit into from
Closed

Rename Binary in OSX (CFBundleExecutable) #195 #244

wants to merge 1 commit into from

Conversation

psxjpc
Copy link
Contributor

@psxjpc psxjpc commented Jan 25, 2016

Tackles the issue #195 by renaming the binary to opts.name

@psxjpc
Rename Binary in OSX (CFBundleExecutable) #195
d5e1d48 
Tackles the issue #195 by renaming the binary to opts.name
malept
malept reviewed Jan 25, 2016
View reviewed changes
mac.js
@@ -99,6 +100,12 @@ module.exports = {
mv(path.dirname(contentsPath), finalAppPath, cb)
})

if (appPlist.CFBundleExecutable !== 'Electron') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what case will this value be Electron? (The bigger question I'm asking is, is the conditional necessary?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that :)

@malept malept added tests-needed Pull request needs tests build-target:mac 🍎 Bundling an Electron app specifically for macOS labels Jan 25, 2016
@malept
Copy link
Member

malept commented Jan 25, 2016

Thank you for your contribution!

Could you add a unit test for your change, to make sure there are no regressions in the future?

Additionally, please note that the continuous integration check failed, in that your change does not conform to our coding standards. That will also need to be fixed before this can be merged.

@malept malept mentioned this pull request Feb 9, 2016
Closed
@florian
Copy link

florian commented Mar 12, 2016

Any updates on this? It's a pretty annoying bug

@malept
Copy link
Member

malept commented Mar 12, 2016

@florian the following needs to happen in order for this to be merged:

  • Coding standards need to be followed
  • A unit test needs to be added so we can prevent regressions of this behavior in the future
  • The PR needs to be rebased on master

Since this hasn't been updated in over a month, feel free to fork this PR and work on it yourself (provided you follow all of the pull request guidelines in our documentation.

@dmurtari dmurtari mentioned this pull request Mar 22, 2016
Merged
@malept malept closed this in #293 Mar 22, 2016
malept added a commit that referenced this pull request Mar 22, 2016
@malept
Merge pull request #293 from dmurtari/master
f631ebb 
Fix OSX Binary Names

Fixes #195.
Closes #244.
@doesdev
Copy link

doesdev commented Apr 10, 2016

I've run into a weird bug after these changes. I got it resolved, but can't for the life of me pin down the actual cause.

I was getting The application ... can't be opened. after updating to > 6.0.0. The fix was to change options.name. At first I thought it was due to a period in the name but that wasn't it, as using the same name all lowercased works. Then I thought it was some kind of naming collision with another option, but changing things that were the same like app-bundle-id didn't fix it either.

It's an odd thing and I don't expect any further investigation of it as changing the name works. I really just wanted to document it here in case someone else runs into it.

@AlicanC
Copy link

AlicanC commented Apr 18, 2016

@Musocrat I can confirm. Thanks for writing the post, it saved me a good amount of time 👍

@develar
Copy link
Contributor

develar commented Apr 18, 2016

@Musocrat Not quite understand — what was changed to fix? If name should be somehow normalised — it should be done by tool :)

@AlicanC
Copy link

AlicanC commented Apr 18, 2016 •
edited

@develar, the fix is using "my app name" instead of "My App Name". Capitalized names used to work on 5.1.0, but they got broken when I updated to 6.0.2 today.

@develar
Copy link
Contributor

develar commented Apr 18, 2016

@AlicanC Thanks, it will be investigated and fixed in the electron-builder as part of electron-userland/electron-builder#288

@develar develar mentioned this pull request Apr 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build-target:mac 🍎 Bundling an Electron app specifically for macOS tests-needed Pull request needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@psxjpc @malept @florian @doesdev @AlicanC @develar