Unify asar options #417
Merged
Unify asar options #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
force-pushed
the
unify-asar-options
branch
from
250c89e
to
6a021c1
Compare
malept
force-pushed
the
unify-asar-options
branch
from
6a021c1
to
529bccf
Compare
malept
force-pushed
the
unify-asar-options
branch
from
529bccf
to
85bce4a
Compare
|
Assuming the OSX tests ever finish, I'll merge this weekend unless there are any objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #353, but it is rebased against master, merges
asar-optionsintoasar, and adds tests.It only enhances
asarand deprecatesasar-unpackandasar-unpack-dir, so only a minor version bump is required.Closes #353.
TODO