Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in extend-info and add support object params #510

Merged
merged 3 commits into from
Oct 29, 2016
Merged

fix typo in extend-info and add support object params #510

merged 3 commits into from
Oct 29, 2016

Conversation

kwolfy
Copy link
Contributor

@kwolfy kwolfy commented Oct 20, 2016

Summarize your changes:
fix typo in extend plist
added object params support for the "extend-info"

packager({
  ...
  'extend-info': {
     ElectronTeamId: 'RJ883jd299'
   }
});

Are your changes appropriately documented?
no, My English is not enough for writing docs

Do your changes have sufficient test coverage?
yes

Does the testsuite pass successfully on your local machine?
yes

@kwolfy kwolfy changed the title fix typo in extend-plist fix typo in extend-plist and add support object params Oct 20, 2016
@kwolfy kwolfy changed the title fix typo in extend-plist and add support object params fix typo in extend-info and add support object params Oct 20, 2016
@malept
Copy link
Member

malept commented Oct 23, 2016

@kwolfy I've updated the docs based on your new feature. Let me know if it's accurate or it needs to be clarified.

@kwolfy
Copy link
Contributor Author

kwolfy commented Oct 24, 2016

@malept Thank you, The doc is right

@malept malept merged commit 578df2b into electron:master Oct 29, 2016
@malept
Copy link
Member

malept commented Oct 29, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants