Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --overwrite options #75

Merged
merged 1 commit into from Jun 28, 2015
Merged

Conversation

tengyifei
Copy link

Fixes #39

Problem does not appear on Windows.

Tested on Mac. Would appreciate anyone to try this on linux.

@junosuarez
Copy link
Contributor

@tengyifei could you please rebase and squash into one commit?

@tengyifei
Copy link
Author

Done.

@tengyifei
Copy link
Author

Any update on when this could get merged?

@max-mapper max-mapper merged commit f39ba8c into electron:master Jun 28, 2015
@kfranqueiro
Copy link
Contributor

It should probably have been noted that this PR never touched the windows platform code path...

I will have this resolved for all 3 centrally in index.js (and in usage.txt and the readme) on the branch that I PR once I figure out rebasing it.

Edit: I just noticed the note in the initial description. I suppose this is only addressing the errors that occur normally if you try to package into an output folder that already exists. In the process of working on --all, though, it made more sense to me to make it explicitly skip or overwrite depending on whether the flag is set. (I could've sworn I saw it cause errors regardless of target platform.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants