Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AVA instead of tape #781

Merged
merged 10 commits into from
Jan 1, 2018
Merged

Use AVA instead of tape #781

merged 10 commits into from
Jan 1, 2018

Conversation

malept
Copy link
Member

@malept malept commented Dec 23, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

AVA is maintained, tape is not. Plus there's a bunch of features that are way better for modern JS, which resulted in less code and less boilerplate.

@malept malept merged commit bc2080c into electron:master Jan 1, 2018
@malept malept deleted the use-ava branch January 1, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant