Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inferring electron-prebuilt-compile versions better #932

Merged
merged 2 commits into from Jan 16, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jan 16, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

In electron-prebuilt-compile 1.6.5, a main file was added, so we can use the normal way of inferring the version instead of using the workaround.

Fixes #909.

CC: @jacobq

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #932 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #932   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         669    672    +3     
=====================================
+ Hits          669    672    +3
Impacted Files Coverage Δ
infer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e686383...6fafbc6. Read the comment docs.

@malept malept merged commit 86f1082 into master Jan 16, 2019
@malept malept deleted the handle-electron-prebuilt-compile-infer-better branch January 16, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant