Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inference where electron-prebuilt-compile points to a non-version #978

Merged
merged 1 commit into from Apr 16, 2019
Merged

Handle inference where electron-prebuilt-compile points to a non-version #978

merged 1 commit into from Apr 16, 2019

Conversation

malept
Copy link
Member

@malept malept commented Apr 16, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #975.

@codecov
Copy link

codecov bot commented Apr 16, 2019 •
edited

Codecov Report

Merging #978 into v14-develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v14-develop   #978   +/-   ##
==========================================
  Coverage          100%   100%           
==========================================
  Files               13     13           
  Lines              671    674    +3     
==========================================
+ Hits               671    674    +3
Impacted Files Coverage Δ
src/infer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd30ab...4aeb521. Read the comment docs.

@malept malept merged this pull request into v14-develop Apr 16, 2019
@malept malept deleted the infer-version-with-url branch April 16, 2019 02:28
jacobq added a commit to jacobq/electron-forge that referenced this pull request Apr 16, 2019
@jacobq
Switch to electron-packager v14.x
8d4b3d5 
This should now include a fix for the "custom electron-prebuilt-compile problem"
See electron/packager#978

Also run `yarn upgrade`
malept added a commit that referenced this pull request Apr 18, 2019
@malept
Handle inference where electron-prebuilt-compile points to a non-vers…
fbfaebc 
…ion (#978)

Fixes #975.
malept added a commit that referenced this pull request May 25, 2019
@malept
Handle inference where electron-prebuilt-compile points to a non-vers…
6291b2b 
…ion (#978)

Fixes #975.
malept added a commit that referenced this pull request Jun 20, 2019
@malept
Handle inference where electron-prebuilt-compile points to a non-vers…
3e4bc54 
…ion (#978)

Fixes #975.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@malept