Skip to content

Commit

Permalink
fix: update node-gyp to ^10.0.0 and fix subsequent breaking changes
Browse files Browse the repository at this point in the history
  • Loading branch information
tarekis authored and clemenshimmer committed Mar 2, 2024
1 parent 96d0d3d commit 99fc935
Show file tree
Hide file tree
Showing 3 changed files with 362 additions and 313 deletions.
6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"got": "^11.7.0",
"node-abi": "^3.45.0",
"node-api-version": "^0.2.0",
"node-gyp": "^9.0.0",
"node-gyp": "^10.0.0",
"ora": "^5.1.0",
"read-binary-file-arch": "^1.0.6",
"semver": "^7.3.5",
Expand All @@ -60,6 +60,7 @@
"@types/chai-as-promised": "^7.1.3",
"@types/debug": "^4.1.5",
"@types/fs-extra": "^9.0.1",
"@types/minipass": "^3.3.5",
"@types/mocha": "^9.0.0",
"@types/node": "^17.0.8",
"@types/node-abi": "^3.0.0",
Expand All @@ -80,6 +81,9 @@
"ts-node": "^10.0.0",
"typescript": "^4.0.2"
},
"resolutions": {
"string-width": "4.2.3"
},
"eslintConfig": {
"parser": "@typescript-eslint/parser",
"parserOptions": {
Expand Down
3 changes: 1 addition & 2 deletions src/module-type/node-gyp/worker.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import NodeGypRunner from 'node-gyp';
import { promisify } from 'util';

process.on('message', async ({
nodeGypArgs,
Expand All @@ -23,7 +22,7 @@ process.on('message', async ({
});
}
}
await promisify(nodeGyp.commands[command.name])(command.args);
await nodeGyp.commands[command.name](command.args);
command = nodeGyp.todo.shift();
}
process.exit(0);
Expand Down
Loading

0 comments on commit 99fc935

Please sign in to comment.