Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump fs-extra from 10.0.0 to 11.2.0 #1139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

threema-danilo
Copy link

@threema-danilo threema-danilo commented May 31, 2024

The type hint for the promise was necessary, because TypeScript complained about the value of type unknown being passed to the fs function.

@threema-danilo threema-danilo requested a review from a team as a code owner May 31, 2024 09:43
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.40%. Comparing base (867e178) to head (556d766).

Files Patch % Lines
src/cache.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1139   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files          21       21           
  Lines         763      763           
  Branches      142      142           
=======================================
  Hits          583      583           
  Misses        125      125           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@threema-danilo
Copy link
Author

Hmm, the updated type library doesn't support node 12 anymore, which is still used in CI.

Node versions below 16 are already EOL. Would you accept a PR that drops support for Node <16?

@dsanders11
Copy link
Member

Would you accept a PR that drops support for Node <16?

Our current policy is to not drop support for older Node.js versions unless truly necessary, since it requires a new major release and we've found each major fractures the install base. If we do a breaking change to v4, we'll want to gather as many other possible breaking changes as we can so they can all happen in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants