chore: add CFA support #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I gave up with Travis CI's Windows support and went back to AppVeyor. Need to re-add the project in AppVeyor, though. |
malept
force-pushed
the
fix-electron-locator
branch
from
df9e032
to
846d39e
Compare
|
|
malept
force-pushed
the
fix-electron-locator
branch
2 times, most recently
from
94d97a7
to
5923ede
Compare
Closed
malept
force-pushed
the
fix-electron-locator
branch
from
4292747
to
e33a858
Compare
malept
commented
Nov 15, 2019
| [ | ||
| path.resolve(__dirname, 'prebuild-shim.js'), | ||
| path.resolve(__dirname, `prebuild-shim.${shimExt}`), |
There was a problem hiding this comment.
The prebuild shim wasn't correctly being run in tests because it assumed that the .js version was always in the same location as src/rebuild.ts.
| @@ -329,7 +331,11 @@ class Rebuilder { | |||
| rebuildArgs.push('--debug'); | |||
| } | |||
|
|
|||
| Object.keys(modulePackageJson.binary || {}).forEach((binaryKey) => { | |||
| for (const binaryKey of Object.keys(modulePackageJson.binary || {})) { | |||
There was a problem hiding this comment.
Switching to for instead of .forEach is more idiomatic, plus it makes the stack trace smaller.
|
|
||
| function packageCommand(command: string, packageName: string) { | ||
| return spawnPromise('npm', [command, packageName], { | ||
| return spawnPromise('npm', [command, '--no-save', packageName], { |
There was a problem hiding this comment.
--no-save prevents the top-level package.json from being overwritten. This is more apparent when developing locally, rather than in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the
asarPR.Also refactors the "locate electron" code/tests so that they're more robust.