Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking for installed headers #7

Merged

Conversation

hongrich
Copy link
Contributor

@hongrich hongrich commented Jun 5, 2015

Fix checking for installed headers to actually pass in nodeVersion as the first param. This also includes a test.

to actually pass in nodeVersion as the first param
Also add a test for this
@hongrich
Copy link
Contributor Author

hongrich commented Jun 5, 2015

I discovered this while looking into #6. I couldn't get to.throw() to work in the test, so I just followed the same pattern you used in the promisify test

anaisbetts added a commit that referenced this pull request Jun 8, 2015
@anaisbetts anaisbetts merged commit 92bfb59 into electron:master Jun 8, 2015
@anaisbetts
Copy link
Contributor

Thanks!

@hongrich hongrich deleted the fix-check-for-installed-headers branch June 29, 2015 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants