Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add machine-id to query #14

Closed
zeke opened this issue Apr 24, 2018 · 5 comments · Fixed by #16
Closed

Add machine-id to query #14

zeke opened this issue Apr 24, 2018 · 5 comments · Fixed by #16

Comments

@zeke
Copy link
Contributor

zeke commented Apr 24, 2018

https://github.com/automation-stack/node-machine-id

@juliangruber
Copy link
Contributor

juliangruber commented Apr 24, 2018

maybe as a query string? feedUrl += '?id=...'? Not sure how to do it otherwise, with the auto-updater module.

@zeke
Copy link
Contributor Author

zeke commented Apr 24, 2018

Yeah was thinking query string. This piece of data will help us identify how many consumers of the new service are using the update-electron-app module. Also it will always be the same string, whereas a user's IP address will change.

@MarshallOfSound
Copy link
Member

This is awkward territory (effectively taking tracking Id's from users machines) this needs to be extremely clearly documented 👍 along with a privacy policy covering how these id's would be used

@timfish
Copy link

timfish commented Apr 24, 2018

node-machine-id also has this issue which means it doesn't work on Windows machines with registry editing disabled.

@zeke
Copy link
Contributor Author

zeke commented Apr 26, 2018

🎉 This issue has been resolved in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants