Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): remove outdated CSS syntax #515

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Feb 17, 2024

I don't think we support this syntax on the website at all anymore (e.g. https://www.electronjs.org/blog/august-2016-roundup), and MDX 3 will explicitly require us to escape these characters in the copy.

@erickzhao erickzhao requested a review from a team as a code owner February 17, 2024 00:54
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-515 February 17, 2024 00:54 Inactive
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link check can be ignored since this is touching legacy blog posts and we don't want to open that can of worms.

@erickzhao erickzhao merged commit 0f46f28 into main Feb 20, 2024
5 of 6 checks passed
@erickzhao erickzhao deleted the fix/standard-syntax-blog branch February 20, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants