Allowed signWithParams with certificateFile/Password #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the logic in parsing the signWithParams to allow for using them alongside the certificate options, rather than instead of them. This stems from times I was debugging the sigining procedure, or wanted to tweak it, but wished to do so without manually building the arguments for the certificate file and password as well. To make this change non-breaking, I added a conditional testing that the user-provided signWithParams contain neither /f nor /p, and only in the case that neither of those exists and both certificateFile and certificatePassword are provided, both are used. Otherwise the behavior is just like it currently is.
MarshallOfSound
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the logic in parsing the signWithParams to allow for using them alongside the certificate options, rather than instead of them.
This stems from times I was debugging the signing procedure, or wanted to tweak it, but wished to do so without manually building the arguments for the certificate file and password as well.
To make this change non-breaking, I added a conditional testing that the user-provided signWithParams contain neither /f nor /p, and only in the case that neither of those exists and both certificateFile and certificatePassword are provided, both are used. Otherwise the behavior is just as it currently is.
I would love to hear thoughts about this change, and if there reasons I might be missing why it's a bad idea. I'm also unsure about how to test it - is there a test suite somewhere? Should I build or use an existing minimal project and see that it behaves as expected?
Thanks!