Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying resources and locales to installer #36

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

voldmar
Copy link
Contributor

@voldmar voldmar commented Mar 11, 2016

Use forward slashes instead of backslashes in .nuspec. I suppose that backslashes in path spec have to be quoted with another backslash, but historically one can use forward slashes in paths while opening files programmatically. The safe way is to use forward slashes in .nuspec and nuget.exe understands them perfectly.

Use forward slashes instead of backslashes in .nuspec. I suppose that backslashes in path spec have to be quoted with another backslash, but historically one can use forward slashes in paths while opening files programmatically. The safe way is to use forward slashes in .nuspec and nuget.exe understands them perfectly.
@havenchyk
Copy link
Contributor

@voldmar could you please prove why it's needed? Is it for cross platform compatibility?

@develar
Copy link
Contributor

develar commented Mar 13, 2016

electron-builder tests successfully passed on all OS and on local OS X machine. I am also interested in the test case.

@havenchyk
Copy link
Contributor

I believe it solves the issue described here #28 (comment). Can be merged if anyone will confirm the solution.

@voldmar
Copy link
Contributor Author

voldmar commented Mar 14, 2016

It solves my issue: I use OS X to develop kiosk app for Windows. I.e. in my left hand I have a Terminal window with editor and building script, and in my right hands I have Parallels with Windows 8.1. Before this patch I had a folder with .exe, a bunch of DLLs and without resources folder with app.asar and atom.asar where all JS are. So when I run .exe I have error that Electron cannot load some .../lib/index.js. With this patch I had running app. So it goes.

@voldmar
Copy link
Contributor Author

voldmar commented Mar 14, 2016

Ah, one more point! One can test that package is valid by checking output of unzip -l YourInstaller.nupkg — it should contain locales and releases folders.

@anaisbetts
Copy link
Contributor

Tested, it works on Windows and if it solves problems on Posix, I'm into it.

anaisbetts added a commit that referenced this pull request Mar 15, 2016
Fix copying resources and locales to installer
@anaisbetts anaisbetts merged commit fc21c9d into electron:master Mar 15, 2016
@voldmar
Copy link
Contributor Author

voldmar commented Mar 20, 2016

Just asking — do you have any plans to release next minor version with my patch? I’m itching to update my package.json :-)

@voldmar voldmar deleted the patch-1 branch March 20, 2016 13:04
@develar
Copy link
Contributor

develar commented Mar 20, 2016

Please note — there is uncorfimed bug report electron-userland/electron-builder#257 Can't check it yet.

@develar
Copy link
Contributor

develar commented Mar 20, 2016

#45 (comment)

So... I think must be reverted ASAP.

@develar
Copy link
Contributor

develar commented Mar 23, 2016

I have prepared new PR #49 to fix this critical bug.

@voldmar Yep, that's strange why / doesn't work on Windows. It is the shame... Well, I don't have time to fix *** windows tools, so, for now it will be better to fix it on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants