-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copying resources and locales to installer #36
Conversation
Use forward slashes instead of backslashes in .nuspec. I suppose that backslashes in path spec have to be quoted with another backslash, but historically one can use forward slashes in paths while opening files programmatically. The safe way is to use forward slashes in .nuspec and nuget.exe understands them perfectly.
@voldmar could you please prove why it's needed? Is it for cross platform compatibility? |
electron-builder tests successfully passed on all OS and on local OS X machine. I am also interested in the test case. |
I believe it solves the issue described here #28 (comment). Can be merged if anyone will confirm the solution. |
It solves my issue: I use OS X to develop kiosk app for Windows. I.e. in my left hand I have a Terminal window with editor and building script, and in my right hands I have Parallels with Windows 8.1. Before this patch I had a folder with .exe, a bunch of DLLs and without |
Ah, one more point! One can test that package is valid by checking output of |
Tested, it works on Windows and if it solves problems on Posix, I'm into it. |
Fix copying resources and locales to installer
Just asking — do you have any plans to release next minor version with my patch? I’m itching to update my package.json :-) |
Please note — there is uncorfimed bug report electron-userland/electron-builder#257 Can't check it yet. |
So... I think must be reverted ASAP. |
Use forward slashes instead of backslashes in .nuspec. I suppose that backslashes in path spec have to be quoted with another backslash, but historically one can use forward slashes in paths while opening files programmatically. The safe way is to use forward slashes in .nuspec and nuget.exe understands them perfectly.