Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to Squirrel 2.0.1 #361

Closed

Conversation

dennisameling
Copy link
Contributor

Follow-up on #354 which was created by @anaisbetts. Squirrel 2.0.1 has been released in the meantime which fixes some issues. This PR includes the 2.0.1 binaries.

From the original PR:

See https://github.com/Squirrel/Squirrel.Windows/releases/tag/2.0.0 for what's new, the tl;dr; for Electron applications is:

  • ARM64 Windows installers can now be built
  • Improvements to MSI installers
  • Log files are More Betterer

@dennisameling
Copy link
Contributor Author

dennisameling commented Nov 3, 2020

Just updated this PR so that it not only enables cross-compiling for Windows arm64 on a x64 host, but it also runs natively on arm64 now 🚀 this PR automatically selects the right 7z.exe and 7z.dll based on host OS architecture.

If you want to easily test this PR, you can do so by installing npm install --save-dev electron-winstaller-test-dennis in any project which uses electron-winstaller.

Just tested this PR with GitHub Desktop on my arm64 Surface Pro X, can confirm the packages are built correctly:

image

Installation also works as expected:

image

image

After installation, I have a working instance of GitHub Desktop:

image

@dennisameling
Copy link
Contributor Author

dennisameling commented Nov 13, 2020

@malept sorry to bother you, but do you think this PR is likely to be reviewed anytime soon? It's currently blocking desktop/desktop#9691. Please let me know if I can be of any further help here. Thanks in advance 🚀

Copy link

@gottogon gottogon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good choice

@niik
Copy link
Contributor

niik commented Nov 30, 2020

@anaisbetts 👋 GitHub Desktop is investigating upgrading to Squirrel 2.0.1, just wanted to check that the issues you mentioned in #354 (comment) about 2.0.0 have all been adequately resolved now?

Let's hold off on this, we found a few issues I want to investigate

@dennisameling
Copy link
Contributor Author

Closing in favor of #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants