Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python updates #976

Merged
merged 17 commits into from
May 30, 2024
Merged

python updates #976

merged 17 commits into from
May 30, 2024

Conversation

simonpintarelli
Copy link
Collaborator

  • fix / cleanup of nlcg python
  • add new pytest

@simonpintarelli simonpintarelli marked this pull request as draft March 16, 2024 23:39
@toxa81
Copy link
Collaborator

toxa81 commented Apr 30, 2024

@simonpintarelli please have a look at the comment about has_augmented_atom(). Otherwise it's good to go

@simonpintarelli
Copy link
Collaborator Author

@toxa81 which comment?

toxa81
toxa81 requested changes Apr 30, 2024
View reviewed changes
src/unit_cell/unit_cell.hpp Outdated Show resolved Hide resolved
@simonpintarelli simonpintarelli marked this pull request as ready for review May 27, 2024 08:24
toxa81
toxa81 approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@toxa81 toxa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toxa81 toxa81 merged commit 5e0fee0 into develop May 30, 2024
3 checks passed
@toxa81 toxa81 deleted the python-nlcg-updates branch May 30, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toxa81 toxa81 toxa81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonpintarelli @toxa81