Add EASTL.natvis to EASTL when using MSVC and install to doc directory #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This looks good to me but it now needs a rebase. |
grojo-ea
reviewed
Jan 28, 2023
CMakeLists.txt
Outdated
| @@ -22,6 +22,15 @@ include(CommonCppFlags) | |||
| file(GLOB EASTL_SOURCES "source/*.cpp") | |||
| add_library(EASTL ${EASTL_SOURCES}) | |||
|
|
|||
| if (MSVC) | |||
| set(EASTL_NATVIS_DIR "doc") | |||
There was a problem hiding this comment.
Could you fix this indentation?
There was a problem hiding this comment.
I've normalized the indentation to use 4 spaces for all new additions, but it looks like indentation in existing files is also inconsistent. Let me know it needs changing.
There was a problem hiding this comment.
Good point, we should probably fix that indentation at some point, but that's separate from this PR. Thanks for fixing it up for the added lines.
|
I've rebased it and applied the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
EASTL.natvisto the EASTL target when using MSVC and installs the file to thedocdirectory, enabling users to use the file without needing to reference the Git repository or manually copy the file.