Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#77 use all link flags from pkg-config #78

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

archie2x
Copy link
Contributor

@archie2x archie2x commented Aug 6, 2022

Uses output of pkg-config --libs instead of pkg-config --variable=libdir

Automatically adds dynamic library dependencies when linking with libraylib.so

@electronstudio
Copy link
Owner

I'm pretty sure that there must have been a reason I didn't use pkg-config --libs in the first place. Raylib doesn't have very good support for pkg-config so I suspect it was that on some platforms this gives wrong results.

@archie2x
Copy link
Contributor Author

archie2x commented Aug 6, 2022 via email

@electronstudio
Copy link
Owner

I think the issue is that some distributions (homebrew on Mac maybe) install both static and dynamic versions of raylib. Then even if you do pkg-config --libs --static you still get the dynamic version. So you have to actually specify libraylib.a to ensure you get the static version.

@archie2x
Copy link
Contributor Author

archie2x commented Aug 6, 2022

I think the issue is that some distributions (homebrew on Mac maybe) install both static and dynamic versions of raylib. Then even if you do pkg-config --libs --static you still get the dynamic version. So you have to actually specify libraylib.a to ensure you get the static version.

I just did it for Linux. I was afraid there were reasons it was done this way for other platforms.

@electronstudio
Copy link
Owner

I think Mac and Windows users will generally be using our binary wheels now. Linux users are probably the only ones compiling, so I’m inclined to accept PR. If we do get any bug reports from that only then try to come up with a more complex solution. (Best thing would be to fix Raylib’s pkg config but that doesn’t seem to be trivial)

@electronstudio
Copy link
Owner

Btw I’ve also considered doing a DRM binary wheel for PI but I’m not sure how to allow user to select if they want the DRM or the X11 one.

@electronstudio electronstudio merged commit 3a6deb2 into electronstudio:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants