add vira-dropdown to vira package #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrovir
force-pushed
the
add-vira-dropdown
branch
from
5833d05
to
fe5e240
Compare
electrovir
force-pushed
the
add-vira-dropdown
branch
from
fe5e240
to
d0f2273
Compare
KylerHansen
approved these changes
Apr 29, 2024
sarangspadalkar
suggested changes
May 2, 2024
packages/vira-book/src/element-book/entries/dropdown/vira-dropdown-item.element.book.ts
Show resolved
Hide resolved
packages/vira-book/src/element-book/entries/dropdown/vira-dropdown-item.element.book.ts
Show resolved
Hide resolved
packages/vira-book/src/element-book/entries/dropdown/vira-dropdown.element.book.ts
Outdated
Show resolved
Hide resolved
packages/vira-book/src/element-book/entries/dropdown/vira-dropdown-item.element.book.ts
Show resolved
Hide resolved
electrovir
commented
May 6, 2024
electrovir
commented
May 6, 2024
add more element book cases close other dropdowns when another dropdown is opened add placeholder test vira-dropdown minor tweaks and fixes
sarangspadalkar
approved these changes
May 7, 2024
electrovir
force-pushed
the
add-vira-dropdown
branch
from
239e2e6
to
23f2566
Compare
electrovir
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
vira-dropdownandvira-dropdown-itemHow to test
Unfortunately I do not have deploy previous setup for this so you'll have to test locally:
npm cicd packages/vira-booknpm startvira-dropdownelement in the vira-book frontend