Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for this repository (:.
It seems we encountered a bug with my colleagues (cc: @luiscardosooliveira).
The error was:
After investigating a little, it seems like
lastItem.height
can be equal to 0.This leads to spaceCount being equal to
Infinity
(from line: )pdf-text-reader/src/index.ts
Line 156 in 06c35be
As we're doing an
Array(spaceCount)
afterwards, it makes the library throw an error.pdf-text-reader/src/index.ts
Line 159 in 06c35be
Adding a condition on
lastItem.height !== 0
corrects the behavior.npm run test
was launched and didn't return any errors. Please feel free to tell us if it's OK for you!