Mypy has been updated to 1.1.1 from 1.0.1 and it now differentiates b…

…etween types of `assignment`, requiring us to use the specialised `method-assign` ignore case
electrumsv · Mar 7, 2023 · f046e0d · f046e0d
1 parent 6c1238a
commit f046e0d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/electrumsv/gui/qt/app.py b/electrumsv/gui/qt/app.py
@@ -247,10 +247,10 @@ def _create_window_for_wallet(self, wallet: Wallet) -> ElectrumWindow:
 
     def _register_wallet_events(self, wallet: Wallet) -> None:
         # NOTE(typing) Some typing nonsense about not being able to assign to a method.
-        wallet.contacts._on_contact_added = self._on_contact_added # type: ignore[assignment]
-        wallet.contacts._on_contact_removed = self._on_contact_removed # type: ignore[assignment]
-        wallet.contacts._on_identity_added = self._on_identity_added # type: ignore[assignment]
-        wallet.contacts._on_identity_removed = self._on_identity_removed # type: ignore[assignment]
+        wallet.contacts._on_contact_added = self._on_contact_added # type: ignore[method-assign]
+        wallet.contacts._on_contact_removed = self._on_contact_removed # type: ignore[method-assign]
+        wallet.contacts._on_identity_added = self._on_identity_added # type: ignore[method-assign]
+        wallet.contacts._on_identity_removed=self._on_identity_removed # type: ignore[method-assign]
 
     def _on_identity_added(self, contact: ContactEntry, identity: ContactIdentity) -> None:
         self.identity_added_signal.emit(contact, identity)

diff --git a/electrumsv/gui/qt/key_dialog.py b/electrumsv/gui/qt/key_dialog.py
@@ -113,7 +113,7 @@ def __init__(self, main_window: ElectrumWindow, account_id: int, key_data: KeyDa
         self._history_list = history_list.HistoryList(self._main_window, self._main_window)
         self._history_list._on_account_change(self._account_id, self._account, False)
         # NOTE(typing) I have no idea why we are suddenly getting "Cannot assign to a method"
-        self._history_list.get_domain = self.get_domain # type: ignore[assignment]
+        self._history_list.get_domain = self.get_domain # type: ignore[method-assign]
         vbox.addWidget(self._history_list)
 
         vbox.addLayout(Buttons(CloseButton(self)))

diff --git a/electrumsv/gui/qt/password_dialog.py b/electrumsv/gui/qt/password_dialog.py
@@ -102,7 +102,7 @@ def __init__(self, text: str='') -> None:
         # Pass-throughs
         self.key_event_signal = self.pw.key_event_signal
         self.returnPressed = self.pw.returnPressed
-        self.setFocus = self.pw.setFocus # type: ignore[assignment]
+        self.setFocus = self.pw.setFocus # type: ignore[method-assign]
         self.setMaxLength = self.pw.setMaxLength
         self.setPlaceholderText = self.pw.setPlaceholderText
         self.setText = self.pw.setText

diff --git a/electrumsv/gui/qt/util.py b/electrumsv/gui/qt/util.py
@@ -939,7 +939,7 @@ class ButtonsTextEdit(QPlainTextEdit, ButtonsWidget):
     def __init__(self, text: Optional[str]=None) -> None:
         QPlainTextEdit.__init__(self, text)
         self.setText = self.setPlainText
-        self.text = self.toPlainText # type: ignore[assignment]
+        self.text = self.toPlainText # type: ignore[method-assign]
         self.buttons: List[QAbstractButton] = []
 
     def resizeEvent(self, event: QResizeEvent) -> None: