Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package installation incorrectly installs data files #27

Closed
rt121212121 opened this issue Feb 2, 2019 · 1 comment
Closed

Python package installation incorrectly installs data files #27

rt121212121 opened this issue Feb 2, 2019 · 1 comment
Milestone

Comments

@rt121212121
Copy link
Contributor

Reported by @SomberNight.

Python packaging supports two data inclusion mechanisms, package_data and data_files. Package data is data included inside the Python package, which for us is the top-level module electrumsv. Data files is where you want to install files, which may be inside the package, alongside it or somewhere nearby, in either an external location (/var, /etc, and so on) or relative to the installation directory.

Research results in claims that package_data and data_files are hard to get right, and it is enough and recommended to just ensure the data files are included in the MANIFEST.in file (which the graft electrumsv will do), and instead set include_package_data=True.

@rt121212121
Copy link
Contributor Author

I can never seem to get the egg to include the data files, but the tgz and zip include them. However, since the eggs are deprecated, no more time will be spent on this.

rt121212121 added a commit that referenced this issue Feb 2, 2019
…the data, that running from the github repo clone works, that Windows builds work, and that presumably MacOS builds also work.. and that doing a 'py -3 setup.py install' also works. The install case seems to fail on the data files not being included in the egg, which seems to be used for installs, but then eggs are deprecated, so..
rt121212121 added a commit that referenced this issue Feb 2, 2019
@rt121212121 rt121212121 added this to the 1.1.0 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant