Strings replaced by StringBuffer

elefevre · Nov 16, 2011 · 2475b77 · 2475b77
1 parent bc3ff96
commit 2475b77
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/FooBarQix/src/net/ericlefevre/FooBarQix.java b/FooBarQix/src/net/ericlefevre/FooBarQix.java
@@ -1,16 +1,17 @@
 package net.ericlefevre;
 
 public class FooBarQix {
+	private final IndividualFooBarQix individualFooBarQix = new IndividualFooBarQix();
 
 	public String asTextUpTo(int topNumber) {
-		String str = "";
+		StringBuilder str = new StringBuilder();
 		for (int i = 1; i <= topNumber; i++) {
-			str += new IndividualFooBarQix().toText(i);
+			str.append(individualFooBarQix.toText(i));
 			if (i < topNumber) {
-				str += "\n";
+				str.append("\n");
 			}
 		}
-		return str;
+		return str.toString();
 	}
 
 	public static void main(String[] args) {

diff --git a/FooBarQix/src/net/ericlefevre/IndividualFooBarQix.java b/FooBarQix/src/net/ericlefevre/IndividualFooBarQix.java
@@ -8,29 +8,28 @@ public class IndividualFooBarQix {
 			"", TEXT_FOR_5, "", TEXT_FOR_7, "", "" };
 
 	public String toText(int number) {
-		String result = //
-		""//
-				+ addTextForDivisible(number, 3)//
-				+ addTextForDivisible(number, 5)//
-				+ addTextForDivisible(number, 7)//
-				+ addTextForDigits(number);
+		StringBuffer result = new StringBuffer();
+		addTextForDivisible(number, 3, result);
+		addTextForDivisible(number, 5, result);
+		addTextForDivisible(number, 7, result);
+		addTextForDigits(number, result);
 
-		return !result.isEmpty() ? result : Integer.toString(number);
+		return result.length() > 0 ? result.toString() : Integer
+				.toString(number);
 	}
 
-	private String addTextForDivisible(int number, int digit) {
-		return (number % digit == 0) ? TEXT[digit] : "";
+	private void addTextForDivisible(int number, int digit, StringBuffer str) {
+		if (number % digit == 0) {
+			str.append(TEXT[digit]);
+		}
 	}
 
-	private String addTextForDigits(int numberToConvert) {
-		String result = "";
-
+	private void addTextForDigits(int numberToConvert, StringBuffer str) {
 		String asString = Integer.toString(numberToConvert);
 		for (int i = 0; i < asString.length(); i++) {
 			int digit = Integer.parseInt("" + asString.charAt(i));
-			result += TEXT[digit];
+			str.append(TEXT[digit]);
 		}
-		return result;
 	}
 
 }