Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11 Statistical analysis tools #15

Merged
merged 1 commit into from Jan 6, 2021
Merged

#11 Statistical analysis tools #15

merged 1 commit into from Jan 6, 2021

Conversation

tigokr
Copy link
Member

@tigokr tigokr commented Jan 4, 2021

  • phpstan 8 level

@tigokr tigokr self-assigned this Jan 4, 2021
@tigokr tigokr force-pushed the feature-phpstan8 branch 2 times, most recently from 2111860 to b69c1cc Compare January 5, 2021 17:53
@tigokr
#11 Statistical analysis tools
4e8f721 
- phpstan 8 level
- coveralls execution fix
@stepanets
Copy link
Member

can we do something with deprecation warnings?

https://travis-ci.com/github/elegant-bro/arrayee/jobs/468863083

@stepanets stepanets added the enhancement New feature or request label Jan 6, 2021
@stepanets stepanets added this to In progress in Elegant Bro via automation Jan 6, 2021
@stepanets stepanets linked an issue Jan 6, 2021 that may be closed by this pull request
Statistical analysis tools #11
Closed
@tigokr
Copy link
Member Author

tigokr commented Jan 6, 2021 •
edited

I'm afraid it's impossible to avoid these deprecation warnings because our support of PHP 7.1 requires to use an old version of symplify/easy-coding-standard -> symplify/package-builder https://github.com/symplify/package-builder/blob/fbdfe363a27070cfdfbc47d5f59e711ed08bb060/src/DependencyInjection/CompilerPass/AutoReturnFactoryCompilerPass.php#L131

only skipping of 7.1 support will recover these errors

@stepanets
Copy link
Member

I'm afraid it's impossible to avoid these deprecation warnings because our support of PHP 7.1 requires to use an old version of symplify/easy-coding-standard

only skipping of 7.1 support will recover these errors

ok, we think about it later)

@tigokr tigokr requested a review from stepanets January 6, 2021 11:57
@tigokr tigokr merged commit 72ea1c5 into master Jan 6, 2021
Elegant Bro automation moved this from In progress to Done Jan 6, 2021
@tigokr tigokr deleted the feature-phpstan8 branch January 6, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepanets stepanets stepanets approved these changes

@anikeevda anikeevda Awaiting requested review from anikeevda

Assignees

@tigokr tigokr

Labels
enhancement New feature or request
Projects
Elegant Bro
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statistical analysis tools
2 participants
@tigokr @stepanets