Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate code to TypeScript #6

Closed
onderceylan opened this issue Aug 15, 2019 · 1 comment · Fixed by #44
Closed

Migrate code to TypeScript #6

onderceylan opened this issue Aug 15, 2019 · 1 comment · Fixed by #44
Assignees
@onderceylan
Labels
enhancement Code improvement, refactor released
Projects
Roadmap
Milestone
1.3.0

Comments

@onderceylan
Copy link
Collaborator

Migrating code to TypeScript will make the contribution easier for the project.

It will also enable us to deliver a compiled code which will help project to be used with earlier versions of node. Due to ES2015 features used in the code, node engine is restricted for versions <8.3.0
@onderceylan onderceylan added the enhancement Code improvement, refactor label Aug 15, 2019
@onderceylan onderceylan added this to the 1.2.0 milestone Aug 15, 2019
@onderceylan onderceylan self-assigned this Sep 1, 2019
@onderceylan onderceylan added this to To do in Roadmap Sep 1, 2019
@onderceylan onderceylan moved this from To do to In progress in Roadmap Sep 1, 2019
onderceylan added a commit that referenced this issue Sep 18, 2019
@onderceylan
refactor(core): migrated project to TypeScript
348a20a 
* Moved executable to /bin folder * Added a build script to generate /dist folder for publishing *
Configured eslint to support TypeScript * Configured jest to work with TypeScript * Downgraded node
dependency to 6.4.0! * Added node shield to README and fixed typos * Updated CONTRIBUTING and added
guidelines for working with TS * Minimized npm package by ignoring more files

fix #6
onderceylan added a commit that referenced this issue Sep 24, 2019
@onderceylan
refactor(core): migrated project to TypeScript
2ab547c 
* Moved executable to /bin folder * Added a build script to generate /dist folder for publishing *
Configured eslint to support TypeScript * Configured jest to work with TypeScript * Downgraded node
dependency to 6.4.0! * Added node shield to README and fixed typos * Updated CONTRIBUTING and added
guidelines for working with TS * Minimized npm package by ignoring more files

fix #6
onderceylan added a commit that referenced this issue Sep 24, 2019
@onderceylan
feat(core): migrated to TypeScript and reduced node dep to 6.4.0
cfc1657 
Migrated to TypeScript and reduced node dep to 6.4.0. Added tests for main.ts.

fix #6
@onderceylan onderceylan mentioned this issue Sep 24, 2019
Merged
@onderceylan onderceylan modified the milestones: 1.2.0, 1.3.0 Sep 24, 2019
Roadmap automation moved this from In progress to Done Sep 25, 2019
onderceylan pushed a commit that referenced this issue Sep 25, 2019
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
57ef5d8 
# [1.3.0](v1.2.0...v1.3.0) (2019-09-25)

### Features

* **core:** migrated to TypeScript and reduced node dep to 6.4.0 ([cfc1657](cfc1657)), closes [#6](#6)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
enhancement Code improvement, refactor released
Projects
No open projects
Roadmap
  
Done
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Typescript migration elegantapp/pwa-asset-generator
1 participant
@onderceylan