Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip Command Fails On WAMP Environments #22

Open
richardginn opened this issue Apr 22, 2018 · 8 comments
Open

Zip Command Fails On WAMP Environments #22

richardginn opened this issue Apr 22, 2018 · 8 comments
Assignees
Labels

Comments

@richardginn
Copy link

richardginn commented Apr 22, 2018

whatiseexampp

I tried to get the SimpleHeader example to work though Xampp and I do not see a NEW module at all.

The first image is with yarn start....

Where can I view it in my browser??

This is what I see after doing Yarn Build.

whatiseexampp2

Yet I still do not see a new module??

What am I do wrong while other people seem to have done it right??

Do I need more than just Xampp running at the same time?? I have yarn and nodejs installed,.

HELP!

UPDATE: This is what I see when I try yarn Zip...

whatiseexampp3

Is this another looking for Wp-config.php file errors?? That would be in the htdocs directory for my windows 10 install of Xampp.

I am even including the includes directory here in a .zip file.

includes.zip

Any help here would be nice.

@elegantthemes elegantthemes deleted a comment from etstaging Apr 23, 2018
@VladET
Copy link

VladET commented Apr 23, 2018

@richardginn That looks good. Is the plugin active under Plugins > Installed Plugins?

@richardginn
Copy link
Author

NO!!! wants to bash head on the wall a few hundred times for not seeing it in the first place

Now I see it....

Now I will attempt to create a new module later on this week.

@richardginn
Copy link
Author

Now for the YARN ZIP command is that an error we are supposed to see??

If it does .zip the module where does the ,zip file show up.

@lots0logs lots0logs added BUG and removed QUESTION labels Apr 24, 2018
@lots0logs lots0logs self-assigned this Apr 24, 2018
@lots0logs lots0logs changed the title What is supposed to happen here?? Not getting this to work at all. Zip Command Fails On WAMP Environments Apr 24, 2018
@VladET
Copy link

VladET commented Apr 25, 2018

@richardginn Looks like this is a bug. @lots0logs will look into it.

In the meantime, when you are ready to package your plugin run yarn build and exclude the following from your .zip package:

/node_modules/
.gitignore
asset-manifest.json
package.json
README.md
yarn.lock

@SJ-James
Copy link

Thanks for listing the excludable files @VladET. That's super helpful in the interim.

@VladET
Copy link

VladET commented Apr 27, 2018

You are welcome, @SJ-James! 😃

@lots0logs
Copy link
Member

Just a quick additional note, you should also exclude all the JSX files as wells as any non-minified scripts and styles.

@haedworm
Copy link

Opening the command line tool as administrator in Windows to run yarn zip works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants