Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix splited response on some servers. #140

Merged
merged 3 commits into from Jan 8, 2016
Merged

Conversation

hereblur
Copy link

@hereblur hereblur commented Jan 5, 2016

Sometimes response from SMTP server is not come in one chunk,
We wait for the last line of response before emit the events.

regarding to http://www.ietf.org/rfc/rfc2821.txt

The format for multiline replies requires that every line, except the
last, begin with the reply code, followed immediately by a hyphen,
"-" (also known as minus), followed by text. The last line will
begin with the reply code, followed immediately by , optionally
some text, and . As noted above, servers SHOULD send the
if subsequent text is not sent, but clients MUST be prepared for it
to be omitted.

For example:

 123-First line
 123-Second line
 123-234 text beginning with numbers
 123 The last line

eleith added a commit that referenced this pull request Jan 8, 2016
Fix splited response on some servers.
@eleith eleith merged commit 452d2ef into eleith:master Jan 8, 2016
@eleith
Copy link
Owner

eleith commented Jan 8, 2016

awesome. thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants