Add background elevation semantic tokens #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Tokens look good to me!
However style-dictionary has issues generating the platform packages.
The names are clashing and the build needs to be fixed.
Tracked as part of element-hq/compound#88
|
@gsouquet So we need to change this due to some Style Dictionary limitations. Also, related W3C DTCG spec issue. I'm on it. |
|
Closing it in favor of #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A much simpler, cleaner implementation of background elevation semantic tokens than #32. It also doesn't introduce any breaking changes for engineers.
This PR adds the necessary architecture for supporting semantics tokens per theme. This is required for scenarios where we can't rely on 1:1/symmetrical mappings of tokens across themes, as briefly explained in PR28.