Switch Prefire to a fork that fixes the configuration and templating,… (

#63) * Switch Prefire to a fork that fixes the configuration and templating, add multi-device snapshots * Try figuring out why the perceptual precission isn't working * Try running the tests on macos-14 * Switch precision back to 1.0
element-hq · Mar 11, 2024 · 517311c · 517311c
1 parent dce4984
commit 517311c
Show file tree

Hide file tree

Showing 19 changed files with 270 additions and 54 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -12,7 +12,7 @@ on:
 jobs:
   tests:
 
-    runs-on: macos-13
+    runs-on: macos-14
 
     steps:
     - name: Checkout code and snapshots

diff --git a/Package.resolved b/Package.resolved
@@ -12,9 +12,9 @@
     {
       "identity" : "prefire",
       "kind" : "remoteSourceControl",
-      "location" : "https://github.com/BarredEwe/Prefire/",
+      "location" : "https://github.com/stefanceriu/Prefire",
       "state" : {
-        "revision" : "996a192263f8056375eb6809e0ff91f1ace40877"
+        "revision" : "982b207efafb9c6ff0c7beae38211c37b918d2b9"
       }
     },
     {

diff --git a/Package.swift b/Package.swift
@@ -12,7 +12,7 @@ let package = Package(
         .package(url: "https://github.com/element-hq/compound-design-tokens.git", exact: "1.2.0"),
         .package(url: "https://github.com/siteline/SwiftUI-Introspect.git", from: "0.9.0"),
         .package(url: "https://github.com/SFSafeSymbols/SFSafeSymbols.git", from: "4.1.1"),
-        .package(url: "https://github.com/BarredEwe/Prefire", revision: "996a192263f8056375eb6809e0ff91f1ace40877"),
+        .package(url: "https://github.com/stefanceriu/Prefire", revision: "982b207efafb9c6ff0c7beae38211c37b918d2b9"),
         .package(url: "https://github.com/pointfreeco/swift-snapshot-testing", from: "1.13.0")
     ],
     targets: [

diff --git a/Sources/Compound/BaseStyles/CompoundButtonStyle.swift b/Sources/Compound/BaseStyles/CompoundButtonStyle.swift
@@ -155,7 +155,6 @@ public struct CompoundButtonStyle_Previews: PreviewProvider, PrefireProvider {
                 Header(title: "Plain")
             }
         }
-        .snapshotWithDefaultPrecision()
     }
 
     public static func states(_ size: CompoundButtonStyle.Size) -> some View {

diff --git a/Sources/Compound/BaseStyles/CompoundToggleStyle.swift b/Sources/Compound/BaseStyles/CompoundToggleStyle.swift
@@ -44,7 +44,6 @@ public struct CompoundToggleStyle_Previews: PreviewProvider, PrefireProvider {
             states
         }
         .padding(32)
-        .snapshotWithDefaultPrecision()
     }
 
     @ViewBuilder

diff --git a/Sources/Compound/Extensions/View.swift b/Sources/Compound/Extensions/View.swift
diff --git a/Sources/Compound/Icons/CompoundIcon.swift b/Sources/Compound/Icons/CompoundIcon.swift
@@ -168,18 +168,14 @@ struct CompoundIcon_Previews: PreviewProvider, PrefireProvider {
     static var previews: some View {
         form
             .previewDisplayName("Form")
-            .snapshotWithDefaultPrecision()
         buttons
             .padding(8)
             .previewLayout(.sizeThatFits)
             .previewDisplayName("Buttons")
-            .snapshotWithDefaultPrecision()
         accessibilityIcons
             .previewDisplayName("Accessibility Icons Only")
-            .snapshotWithDefaultPrecision()
         accessibilityLabels
             .previewDisplayName("Accessibility Labels")
-            .snapshotWithDefaultPrecision()
     }
 
     static var accessibilityIcons: some View {

diff --git a/Sources/Compound/List/ListInlinePicker.swift b/Sources/Compound/List/ListInlinePicker.swift
@@ -66,7 +66,6 @@ struct ListInlinePicker_Previews: PreviewProvider, PrefireProvider {
                     .labelsHidden()
                 }
             }
-            .snapshotWithDefaultPrecision()
         }
     }
 }
diff --git a/Sources/Compound/List/ListRow.swift b/Sources/Compound/List/ListRow.swift
@@ -256,7 +256,6 @@ public struct ListRow_Previews: PreviewProvider, PrefireProvider {
             othersSection
         }
         .compoundList()
-        .snapshotWithDefaultPrecision()
     }
 
     static var labels: some View {
@@ -434,6 +433,5 @@ struct ListRowLoadingSelection_Previews: PreviewProvider, PrefireProvider {
                     kind: .selection(isSelected: false) { })
         }
         .compoundList()
-        .snapshotWithDefaultPrecision()
     }
 }
diff --git a/Sources/Compound/List/ListRowAccessory.swift b/Sources/Compound/List/ListRowAccessory.swift
@@ -112,7 +112,6 @@ struct ListRowAccessory_Previews: PreviewProvider, PrefireProvider {
                 .disabled(true)
         }
         .previewDisplayName("Accessories")
-        .snapshotWithDefaultPrecision()
     }
 
     static func row(title: String, accessory: ListRowAccessory) -> some View {
@@ -134,6 +133,5 @@ struct MultiUnselectedAccessory_Previews: PreviewProvider, PrefireProvider {
             }
         }
         .previewDisplayName("Fake circle icon")
-        .snapshotWithDefaultPrecision()
     }
 }
diff --git a/Sources/Compound/List/ListRowButtonStyle.swift b/Sources/Compound/List/ListRowButtonStyle.swift
@@ -72,6 +72,5 @@ public struct ListRowButtonStyle_Previews: PreviewProvider, PrefireProvider {
             .listRowInsets(EdgeInsets())
         }
         .compoundList()
-        .snapshotWithDefaultPrecision()
     }
 }
diff --git a/Sources/Compound/List/ListRowLabel.swift b/Sources/Compound/List/ListRowLabel.swift
@@ -356,6 +356,5 @@ struct ListRowLabel_Previews: PreviewProvider, PrefireProvider {
             }
         }
         .compoundList()
-        .snapshotWithDefaultPrecision()
     }
 }
diff --git a/Sources/Compound/List/ListRowTrailingSection.swift b/Sources/Compound/List/ListRowTrailingSection.swift
@@ -90,7 +90,6 @@ struct ListRowTrailingSection_Previews: PreviewProvider, PrefireProvider {
             details
             withAccessory
         }
-        .snapshotWithDefaultPrecision()
     }
 
     static var details: some View {

diff --git a/Sources/Compound/List/ListStyles.swift b/Sources/Compound/List/ListStyles.swift
@@ -80,7 +80,6 @@ struct ListTextStyles_Previews: PreviewProvider, PrefireProvider {
         }
         .compoundList()
         .previewDisplayName("Form")
-        .snapshotWithDefaultPrecision()
 
         List {
             Section {
@@ -96,6 +95,5 @@ struct ListTextStyles_Previews: PreviewProvider, PrefireProvider {
         }
         .compoundList()
         .previewDisplayName("List")
-        .snapshotWithDefaultPrecision()
     }
 }
diff --git a/Sources/Compound/Text Field Styles/SearchFieldStyle.swift b/Sources/Compound/Text Field Styles/SearchFieldStyle.swift
@@ -78,7 +78,6 @@ struct SearchStyle_Previews: PreviewProvider, PrefireProvider {
         }
         .tint(.compound.textActionPrimary)
         .previewDisplayName("List")
-        .snapshotWithDefaultPrecision()
 
         NavigationStack {
             Form {
@@ -104,6 +103,5 @@ struct SearchStyle_Previews: PreviewProvider, PrefireProvider {
         }
         .tint(.compound.textActionPrimary)
         .previewDisplayName("Form")
-        .snapshotWithDefaultPrecision()
     }
 }
diff --git a/Tests/.prefire.yml b/Tests/.prefire.yml
diff --git a/Tests/CompoundTests/.prefire.yml b/Tests/CompoundTests/.prefire.yml
@@ -0,0 +1,7 @@
+test_configuration:
+  - simulator_device: "iPhone15"
+  - required_os: 17
+  - template_file_path: PreviewTests.stencil
+  - snapshot_devices:
+    - iPhone 15
+    - iPad