Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read receipt and typing notifs of person on ignore list shouldn't be shown #2965

Open
Bubu opened this issue Mar 5, 2021 · 5 comments
Open

Comments

@Bubu
Copy link
Contributor

Bubu commented Mar 5, 2021

Describe the bug
If I ignore a person, that persons RR is still shown along the timeline. Element-web doesn't do this.
Typing notifs are also shown from an ignored person. Element-web does do this as well.

To Reproduce

  • Ignore a person
  • Have that person actively read a chat you are in
  • See the RR next to new messages

Expected behavior
RR of ignored person is not shown.

Additional context

  • App version and store: 1.1.0-F
  • Homeserver: bubu1.eu
@Bubu
Copy link
Contributor Author

Bubu commented Jun 27, 2021

It also shows typing notifs of ignored users. :-(

@Bubu Bubu changed the title Read receipt of person on ignore list shouldn't be shown Read receipt and typing notifs of person on ignore list shouldn't be shown Jun 27, 2021
@bmarty
Copy link
Member

bmarty commented Jun 28, 2021

According to the spec, it's not clear to me if read-receipt and typing notification (so ephemeral events) have to be filtered out by the server or by the client.

I would argue that it could have more sense that the server filters them out. The less the clients have to compute things, the better the perf.

@anoadragon453 what do you think about ephemeral event filtering for ignored users?

Also there are other problems to fix about ignoring users, with higher priority: https://github.com/vector-im/element-android/labels/feature%3Aignored_users

@Bubu
Copy link
Contributor Author

Bubu commented Jun 28, 2021

Read-receipts are PDUs though afaik?

@Bubu
Copy link
Contributor Author

Bubu commented Jun 28, 2021

Updated the issue with the information that ele-web also suffers from the typing notif problem, even though it does do the RR one correctly.

@bmarty bmarty added this to the Sprint - Element 1.1.13 milestone Jul 5, 2021
@bmarty bmarty removed this from the Sprint - Element 1.1.13 milestone Aug 31, 2021
@bmarty
Copy link
Member

bmarty commented Apr 21, 2022

Yes this is element-hq/element-web#6552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants