Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when clicking on ViewEvent source actions #4279

Closed
2 tasks done
bmarty opened this issue Oct 20, 2021 · 4 comments
Closed
2 tasks done

Crash when clicking on ViewEvent source actions #4279

bmarty opened this issue Oct 20, 2021 · 4 comments
Assignees
@ganfra @BillCarsonFr
Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash
Projects
Android App Team

Comments

@bmarty
Copy link
Member

bmarty commented Oct 20, 2021 •
edited

Probably due to the migration to MvRx2, see the stack trace:

    java.lang.NoSuchMethodError: No direct method <init>(Landroidx/lifecycle/LifecycleOwner;Lkotlin/jvm/functions/Function0;)V in class Lcom/airbnb/mvrx/lifecycleAwareLazy; or its super classes (declaration of 'com.airbnb.mvrx.lifecycleAwareLazy' appears in /data/app/im.vector.app.debug-czukF-LVif-ZqSrtYwRdEw==/base.apk)
        at org.billcarsonfr.jsonviewer.JSonViewerFragment.<init>(JSonViewerFragment.kt:88)
        at org.billcarsonfr.jsonviewer.JSonViewerFragment$Companion.newInstance(JSonViewerFragment.kt:71)
        at org.billcarsonfr.jsonviewer.JSonViewerDialog.onActivityCreated(JSonViewerDialog.kt:29)
        at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:2996)
@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 20, 2021
@bmarty bmarty added this to Backlog (Unsorted) in Android App Team Oct 20, 2021
@RiotRobot RiotRobot added this to Incoming in Issue triage Oct 20, 2021
@bmarty
Copy link
Member Author

bmarty commented Oct 21, 2021

@BillCarsonFr will update his lib org.billcarsonfr.jsonviewer

@bmarty bmarty moved this from Backlog (Unsorted) to In Design Review in Android App Team Oct 21, 2021
@bmarty bmarty moved this from In Design Review to In progress in Android App Team Oct 21, 2021
@bmarty
Copy link
Member Author

bmarty commented Oct 21, 2021

First point done on BillCarsonFr/JsonViewer@a8fa35d
@ganfra to create a PR on this project.

@bmarty bmarty removed this from Incoming in Issue triage Oct 21, 2021
@ganfra
Copy link
Contributor

ganfra commented Oct 21, 2021

Adding test will be done on another PR, along fixing the localhost issue for synapse config.

ganfra pushed a commit that referenced this issue Oct 21, 2021
Fix crash when clicking on ViewEvent source actions #4279
d41ff50
@ganfra ganfra mentioned this issue Oct 21, 2021
Merged
@bmarty
Copy link
Member Author

bmarty commented Oct 21, 2021

Crash fixed on 1.3.5

Remaining point converted to a dedicated issue

@bmarty bmarty closed this as completed Oct 21, 2021
Android App Team automation moved this from In progress to Merged Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganfra ganfra

@BillCarsonFr BillCarsonFr

Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash
Projects
Android App Team
Merged
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmarty @ganfra @BillCarsonFr