Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the top bar in a room #4642

Closed
daniellekirkwood opened this issue Dec 6, 2021 · 9 comments
Closed

Update the top bar in a room #4642

daniellekirkwood opened this issue Dec 6, 2021 · 9 comments
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021

This issue is: Ready to Build

Problem

Rooms feel cluttered and messy and there's no 'breathing' space at the top of the screen.

Solution

Update the bar at the top of the room to match iOS

Screenshot 2021-12-15 at 21 32 16

Figma file: https://www.figma.com/file/8gIgD79bQoWdtfK3MtX59G/WTF-Moments?node-id=1%3A7117

PR should require a review from @amshakal

Related: #3296 PR should probably fixes the 2 issues at the same time

@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort labels Dec 6, 2021
@RiotRobot RiotRobot added this to Incoming in Issue triage Dec 6, 2021
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Dec 9, 2021
@daniellekirkwood daniellekirkwood added this to Next Sprint in Android App Team Dec 13, 2021
@daniellekirkwood daniellekirkwood moved this from Next Sprint to Need Design in Android App Team Dec 13, 2021
@daniellekirkwood
Copy link
Contributor Author

@amshakal Can you draw us a quick mockup of what the top bar should look like? I think G may already have mockups that we could attach here... It will also have to consider Threads panel access :)

@daniellekirkwood daniellekirkwood added the X-Needs-Design May require input from the design team label Dec 13, 2021
@amshakal
Copy link

Consider removing room description from the header and moving it to room settings, similar to how iOS handles it. Here is a mockup for both light and dark screens.

Screenshot 2021-12-15 at 21 32 16

Figma file: https://www.figma.com/file/8gIgD79bQoWdtfK3MtX59G/WTF-Moments?node-id=1%3A7117

Pending/to dicuss:

  • If typing should stay up where the header is or should we move it down like iOS.

@daniellekirkwood
Copy link
Contributor Author

Thanks, Amsha! This looks great.

As for the typing notification, there's another issue tracking that: #3296

@daniellekirkwood daniellekirkwood removed the X-Needs-Design May require input from the design team label Jan 4, 2022
@daniellekirkwood daniellekirkwood moved this from Need Design to Next Sprint in Android App Team Jan 4, 2022
@daniellekirkwood
Copy link
Contributor Author

Have removed the Needs Design label and added Amsha's screenshots to the description. This issue is now ready to be built

@daniellekirkwood daniellekirkwood moved this from Next Sprint to WTFs & Papercuts in Android App Team Jan 10, 2022
@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@bmarty bmarty added this to the WTF ready list milestone Jan 31, 2022
@ahmed-radhouane ahmed-radhouane self-assigned this Feb 9, 2022
@ahmed-radhouane ahmed-radhouane moved this from WTFs & Papercuts to Current Sprint in Android App Team Feb 11, 2022
@ahmed-radhouane ahmed-radhouane moved this from Current Sprint to In progress in Android App Team Feb 11, 2022
@ahmed-radhouane
Copy link
Contributor

Hello @daniellekirkwood
I have some questions about this issue from what I found in the implementation.

1 - I found multi badges that are overlapped, related to the room image, one on top of the other

  • An item that indicate presence state (Green / gray circle) which I think it is deprecated ? I do not see it in the application. Can you confirm this

Capture d’écran 2022-02-11 à 16 02 38

  • Second one : an icon that represent the public state,

Capture d’écran 2022-02-11 à 16 04 54

If I set the verification shield like described in the Figma file it will overlap the previous two cases, or functionally I'm not sure if different cases could coexiste at the same.

2 - For the toolbar actions , in android we have a menu that enable users to access more actions

Capture d’écran 2022-02-11 à 16 12 36

technically I'd like to be sure that we keep this icon, (3 dots) and we reduce size between the other icons ?

ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - remove typing message notification from room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - update image and badge in room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - revert vector_settings_round_avatar.xml file to develop state.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - use ObjectAnimator instead of ValueAnimator in TypingMessageDots.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - revert vector_settings_round_avatar.xml file to develop state.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - use ObjectAnimator instead of ValueAnimator in TypingMessageDots.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - remove typing message notification from room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - update image and badge in room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
 - remove typing message notification from room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
 - update image and badge in room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
- remove subtitle in room toolbar.
- update shiled and connected icon in toolbar main picture.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
- reduce extra padding between menu item.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
- adding the changelog file.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
@ahmed-radhouane ahmed-radhouane moved this from In progress to In Code Review in Android App Team Feb 24, 2022
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - revert vector_settings_round_avatar.xml file to develop state.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - use ObjectAnimator instead of ValueAnimator in TypingMessageDots.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - revert vector_settings_round_avatar.xml file to develop state.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - use ObjectAnimator instead of ValueAnimator in TypingMessageDots.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
 - Fixing after code review.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
 - remove typing message notification from room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
 - update image and badge in room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
- remove subtitle in room toolbar.
- update shiled and connected icon in toolbar main picture.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
- reduce extra padding between menu item.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
- adding the changelog file.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
 - Fixing after code review.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
 - remove typing message notification from room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
 - update image and badge in room toolbar.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
- remove subtitle in room toolbar.
- update shiled and connected icon in toolbar main picture.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
- reduce extra padding between menu item.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
- adding the changelog file.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
ahmed-radhouane added a commit that referenced this issue Mar 3, 2022
 - Fixing after code review.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
@daniellekirkwood
Copy link
Contributor Author

Hi @ahmed-radhouane Could you confirm the status of this issue please? It's closed on the WTF board but Open as an issue... Thanks!

@ouchadam
Copy link
Contributor

ouchadam commented Mar 9, 2022

this is done (and merged!) as part of #5213, will be included in the 1.4.4 release

@ouchadam ouchadam closed this as completed Mar 9, 2022
Issue triage automation moved this from Triaged to Closed Mar 9, 2022
Android App Team automation moved this from In Code Review to Merged Mar 9, 2022
@daniellekirkwood
Copy link
Contributor Author

Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
Development

No branches or pull requests

5 participants