Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to room lists Android #4643

Closed
daniellekirkwood opened this issue Dec 6, 2021 · 14 comments
Closed

Add filter to room lists Android #4643

daniellekirkwood opened this issue Dec 6, 2021 · 14 comments
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021

This issue is: Ready to Build

Problem

Users cannot filter the People or Rooms list. This is frustrating if they're trying to find something in the list quickly.

Solution

Add a filter input field to the top of each list view. Similar to iOS, it is only visible when the user starts scrolling down. This means that it doesn't take up any unnecessary real estate but is there if the user starts to look for something (by scrolling down)

Screenshot 2021-12-13 12 43 47

Requested reviewers

@amshakal

@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort labels Dec 6, 2021
@RiotRobot RiotRobot added this to Incoming in Issue triage Dec 6, 2021
@bmarty
Copy link
Member

bmarty commented Dec 6, 2021

Have you seen the magnifier icon at top right?

@daniellekirkwood
Copy link
Contributor Author

Yes, this is supposed to be a "search" capability but is currently acting like a filter...

@bmarty Do we have a "Search" function on Android (like in iOS)?

@daniellekirkwood daniellekirkwood added this to Next Sprint in Android App Team Dec 13, 2021
@daniellekirkwood
Copy link
Contributor Author

Screenshot 2021-12-13 12 43 47

@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Dec 21, 2021
@daniellekirkwood daniellekirkwood moved this from Next Sprint to WTFs & Papercuts in Android App Team Jan 10, 2022
@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@bmarty bmarty added this to the WTF ready list milestone Jan 31, 2022
@bmarty
Copy link
Member

bmarty commented Jan 31, 2022

@daniellekirkwood do you want us to add the same filter UX than on the room member list?

See below:

room_member_filtering

@daniellekirkwood
Copy link
Contributor Author

@bmarty This is the search functionality that exists today?

I think it will act similarly to this - @amshakal will be able to confirm the behaviour. Previously we'd chatted about it acting the same as iOS

@daniellekirkwood daniellekirkwood changed the title Add filter to room lists Add filter to room lists Android Feb 7, 2022
@daniellekirkwood
Copy link
Contributor Author

On iOS we're adding the Filter icon: element-hq/element-ios#5250

@mnaturel mnaturel self-assigned this Feb 15, 2022
@mnaturel
Copy link
Contributor

Hi @daniellekirkwood , I am currently implementing this issue and I am wondering if the search icon should remain in the app. In fact, the search screen provides the same functionalities of filtering except we are able to filter rooms and messages at the same time.

@daniellekirkwood
Copy link
Contributor Author

Great question @mnaturel

@amshakal as the Android search feature is a filter, do we want to remove the need for the input field and instead update the search icon to a filter icon? WDYT?

@mnaturel mnaturel moved this from WTFs & Papercuts to In progress in Android App Team Feb 16, 2022
@amshakal
Copy link

Hey! Yeah, I think we should change it to filter icon so we are not confusing the user. This is a quick fix for now as the team works on improving search and IA on Android in the coming weeks/months.

@mnaturel
Copy link
Contributor

@daniellekirkwood @amshakal Thanks for your replies! I have already done the moving of the filter bar into the rooms/messages tabs. 😄 But right now, what I did is not related to scrolling behavior (it is always displayed and sticky) since it is a bit more complicated to implement. So the answer to my question might be different. What UX is best for user?

  1. Having possibility to filter directly when seeing lists. So in this case we remove the search icon from top right menu.
  2. Click on a button to go in a dedicated filter screen. In this case, we simply replace the search icon by a filter icon. There are no changes to the existing UX.

@mnaturel
Copy link
Contributor

After more discussion, we will go the low effort changes: replacement of the search icon by a filter icon.

@amshakal
Copy link

Hey! Sorry for the back and forth. I think let's gow with replacing the search icon with filter icon to avoid confusion. This will be a low effort, high impact solution given that in user testing sessions, almost every android user tapped on the search icon to look for someone to start a chat with.

@bmarty
Copy link
Member

bmarty commented Feb 17, 2022

#1384 was the reason we change the icon from filter to magnifier FTR

@amshakal
Copy link

I see, I think it's misleading to have search icon when they can't technically search. :/
Will make sure to pass on these insights to Nique for upcoming Search + IA work.

bmarty added a commit that referenced this issue Feb 17, 2022
#4643: Home screen: replacing the search icon by a filter icon in the menu
Issue triage automation moved this from Triaged to Closed Feb 17, 2022
Android App Team automation moved this from In Code Review to Merged Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
Development

No branches or pull requests

4 participants