Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vctr_unread_room_badge and the values and just use vctr_content_secondary. #5225

Closed
bmarty opened this issue Feb 14, 2022 · 1 comment
Closed

Remove vctr_unread_room_badge and the values and just use vctr_content_secondary. #5225

bmarty opened this issue Feb 14, 2022 · 1 comment
Assignees
@mnaturel
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
Issue triage Android App Team
Milestone
WTF ready list

Comments

@bmarty
Copy link
Member

bmarty commented Feb 14, 2022

Ok, so maybe we can remove vctr_unread_room_badge and the values and just use vctr_content_secondary.

Originally posted by @bmarty in #5189 (comment)
@RiotRobot RiotRobot added this to Incoming in Issue triage Feb 14, 2022
@bmarty bmarty changed the title Ok, so maybe we can remove vctr_unread_room_badge and the values and just use vctr_content_secondary. Remove vctr_unread_room_badge and the values and just use vctr_content_secondary. Feb 14, 2022
@ouchadam ouchadam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 15, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Feb 15, 2022
@bmarty bmarty added this to the WTF ready list milestone Feb 17, 2022
@mnaturel mnaturel self-assigned this Feb 18, 2022
@mnaturel mnaturel added this to In progress in Android App Team Feb 18, 2022
@mnaturel mnaturel mentioned this issue Feb 18, 2022
Merged
15 tasks
@mnaturel mnaturel moved this from In progress to In Code Review in Android App Team Feb 18, 2022
bmarty added a commit that referenced this issue Feb 21, 2022
@bmarty
Merge pull request #5263 from vector-im/feature/mna/5225-remove-color…
5bd8247 
…-resource

#5225 Replace color "vctr_unread_room_badge" by "vctr_content_secondary"
@bmarty
Copy link
Member Author

bmarty commented Feb 21, 2022

In EA 1.4.2

@bmarty bmarty closed this as completed Feb 21, 2022
Issue triage automation moved this from Triaged to Closed Feb 21, 2022
Android App Team automation moved this from In Code Review to Merged Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
Android App Team
Merged
Issue triage
Closed
Milestone
WTF ready list
Development

No branches or pull requests
3 participants
@ouchadam @bmarty @mnaturel