Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign out just after sign in makes the app crash #724

Closed
bmarty opened this issue Dec 2, 2019 · 1 comment
Closed

Sign out just after sign in makes the app crash #724

bmarty opened this issue Dec 2, 2019 · 1 comment
Labels
A-Logout Z-Crash
Milestone
Sprint6

Comments

@bmarty
Copy link
Member

bmarty commented Dec 2, 2019

To reproduce:

  • Sign in to RiotX
  • Sign out fast, i.e. just after the sign in

Observed:

  • RiotX crashes because the crypto is still in the process of uploading the one time keys and wants to update the crypto DB, which has been deleted during the sign out.

P2 because the scenario (fast logout) will rarely happen, and maybe this will be fixed when the crypto code will be improved.

I create the issue mainly to not forget to test this case.
bmarty added a commit that referenced this issue Dec 3, 2019
@bmarty
Attempt to properly cancel the crypto module when user signs out (#724)
44a5be9
@bmarty bmarty added this to the Sprint6 milestone Dec 3, 2019
bmarty added a commit that referenced this issue Dec 4, 2019
@bmarty
Attempt to properly cancel the crypto module when user signs out (#724)
3623072 
Attempt to properly cancel the crypto module when user signs out (#724)
@bmarty
Copy link
Member Author

bmarty commented Dec 4, 2019

Fixed by #726

@bmarty bmarty closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Logout Z-Crash
Projects
None yet
Milestone
Sprint6
Development

No branches or pull requests
1 participant
@bmarty