Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSC3912 implementation: Redaction of related events #8481

Closed
giomfo opened this issue May 29, 2023 · 0 comments
Closed

Update MSC3912 implementation: Redaction of related events #8481

giomfo opened this issue May 29, 2023 · 0 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented May 29, 2023

Description:

Since MSC3912 has been implemented by #7988, we introduced 2 changes into the MSC for which we need to update this implementation :

  • the new property with_relations has been renamed with_rel_types (to prevent us from introducing a new term ("relations") to refer to event relationships). Only the stable name is changed, we keep the existing unstable one.
  • we introduced a catch-all "*" value, which if found in the list means "any relation type"

We should apply changes in the SDK only for the first point. The SDK seems already support the second point.
This second point should be taken into account mainly in a moderation tool where the client may not be aware of the relation types associated with an event. I'm not sure there is already a use case at the application level

Are you willing to provide a PR?

Yes

@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label May 29, 2023
@RiotRobot RiotRobot added this to Incoming in Issue triage May 29, 2023
@yostyle yostyle moved this from Incoming to Triaged in Issue triage Jun 23, 2023
@giomfo giomfo closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Development

No branches or pull requests

1 participant