Update MSC3912 implementation: Redaction of related events #8532
Conversation
yostyle
requested review from
a team,
bmarty and
giomfo
and removed request for
a team
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/auth/version/Versions.kt
Outdated
Show resolved
Hide resolved
| @@ -165,6 +164,5 @@ internal fun Versions.doesServerSupportRemoteToggleOfPushNotifications(): Boolea | |||
| * @return true if event redaction with relations is supported | |||
| */ | |||
| internal fun Versions.doesServerSupportRedactEventWithRelations(): Boolean { | |||
There was a problem hiding this comment.
This method just let you know if the feature is supported or not. There is no way to know if this feature is unstable or not. This is a potential pb, because the name of the attribute depends on the stability of the feature.
This remark is not limited to this feature. This concerns all the features handled here.
I don't know if @bmarty wants to improve this here. This remark has to be taken into account at least for EX.
Here I would add a second method
doesServerSupportStableRedactionOfRelatedEvents
and rename the current one: doesServerSupportUnstableRedactionOfRelatedEvents
| val withRelations: List<String>? = null, | ||
| ) | ||
| ) { | ||
| fun getBestWithRelations() = withRelations ?: unstableWithRelations |
There was a problem hiding this comment.
This function should select the right option according to the stability of the feature
...oid/src/main/java/org/matrix/android/sdk/internal/session/room/send/LocalEchoEventFactory.kt
Outdated
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/tasks/RedactEventTask.kt
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Type of change
Content
#8481
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist