Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RustCrypto breaks Sign in with QR feature #8653

Closed
hughns opened this issue Sep 25, 2023 · 5 comments · Fixed by #8654
Closed

RustCrypto breaks Sign in with QR feature #8653

hughns opened this issue Sep 25, 2023 · 5 comments · Fixed by #8654
Assignees
Labels
A-E2EE A-Signin T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@hughns
Copy link
Member

hughns commented Sep 25, 2023

The RustCrypto.setDeviceVerification() function does not have an implementation which breaks the Sign in with QR feature.

Can we get this implemented or is there an alternative function to use?

@BillCarsonFr
Copy link
Member

I don't think you need to set local trust at all?
The other device is cross signed, and if you trust the master key now, you 'll trust it because it's signed by the now trusted SSK

@BillCarsonFr BillCarsonFr self-assigned this Sep 25, 2023
@hughns
Copy link
Member Author

hughns commented Sep 25, 2023

I don't think you need to set local trust at all? The other device is cross signed, and if you trust the master key now, you 'll trust it because it's signed by the now trusted SSK

As per offline conversation: it is intended that the Sign in with QR function works with a deployment that isn't using cross-signing. As such, this is the point in setting the existing device as locally trusted after the new device has signed in.

@BillCarsonFr
Copy link
Member

deployment that isn't using cross-signing

A lot of things expect cross signing nowadays. How can you disable it? there is a setting?

@hughns
Copy link
Member Author

hughns commented Sep 26, 2023

A lot of things expect cross signing nowadays. How can you disable it? there is a setting?

Yes, you can make it so that the Element clients don't prompt to set up cross-signing (nor automatically set it up).

@julioromano julioromano added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-E2EE A-Signin labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-Signin T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
3 participants