Hotfix/crypto 0.3.14/qr code #2632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit seems to be part of main: 1d08ffa? |
BillCarsonFr
changed the base branch from
main
to
jmartinesp/add-x86-64-workaround-to-crypto-sdk
I updated the base |
15 tasks
|
Just realized that my review was requested here. Though given "SHOULD NOT BE MERGED" in the issue description, why does this PR exist in the first place? I'm a bit confused. |
It's a maintenance branch on an old version of the sdk for the android bindings. Android bindings are a bit late and we needed a hotfix. |
|
Okay, have restored the branch since it kinda sounds like it's still needed? Unlike the PR.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose some missing API to fix element-hq/element-android#8653
SHOULD NOT BE MERGED
It's a maintanance branch for the currently released android sdk
Signed-off-by: