Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we hide the algo used when turning on encryption #897

Closed
manuroe opened this issue Jan 24, 2020 · 2 comments · Fixed by #911
Closed

Can we hide the algo used when turning on encryption #897

manuroe opened this issue Jan 24, 2020 · 2 comments · Fixed by #911
Assignees
Labels
A-E2EE S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Community-PR Issue is solved by a community member's PR Z-UI UX
Milestone

Comments

@manuroe
Copy link
Member

manuroe commented Jan 24, 2020

From riot-web created by AmandineLP: element-hq/element-web#8829

at least on /app as 'Amandine turned on end-to-end encryption (algorithm m.megolm.v1.aes-sha2)' is ugly as hell

@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems p1 Z-UI UX Z-Community-PR Issue is solved by a community member's PR labels Jan 24, 2020
@jryans
Copy link

jryans commented Jan 24, 2020

While chatting more with @ara4n, he would like to have some kind of handling of unknown algorithms at the same time as the propose hiding here. I think he came up with a decent approach:

  • When the algorithm is the one we expect (m.megolm.v1.aes-sha2), hide the algorithm as in this existing PR: %(senderName)s turned on end-to-end encryption.
  • For anything else, show the algorithm as unrecognised: %(senderName)s turned on end-to-end encryption (unrecognised algorithm %(algorithm)s).

@bmarty bmarty added this to the Sprint10 milestone Jan 27, 2020
@bmarty
Copy link
Member

bmarty commented Jan 27, 2020

@jryans I think it could even warn a bit more if m.megolm.v1.aes-sha2 is already the current algo in a e2e room, like, say: "%(senderName)s is trying to change end-to-end encryption algorithm of the room to %(algorithm)s, which is forbidden". Not sure that it can happen (the sent event should probably be rejected by the homeserver?)

@bmarty bmarty self-assigned this Jan 28, 2020
@bmarty bmarty modified the milestones: Sprint10, Sprint9 Jan 28, 2020
@jryans jryans added the phase:1 label Feb 12, 2020
@kittykat kittykat added the S-Minor Impairs non-critical functionality or suitable workarounds exist label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Community-PR Issue is solved by a community member's PR Z-UI UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants