Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negotiate E2E by default for DMs #907

Closed
manuroe opened this issue Jan 27, 2020 · 1 comment
Closed

Negotiate E2E by default for DMs #907

manuroe opened this issue Jan 27, 2020 · 1 comment
Assignees
@bmarty
Milestone
Sprint9

Comments

@manuroe
Copy link
Member

manuroe commented Jan 27, 2020

From riot-web created by jryans: element-hq/element-web#12005

When the cross-signing labs flag is on, we want to create DMs as E2E by default. There are no UX changes or toggles in the create DM flow for this. Since not all users support E2E yet (bots, bridges, people with only non-E2E clients), we need to be a bit careful.

When creating the DM room, check if the other user has shared device keys. If yes, then create an encrypted room, otherwise fallback to unencrypted.
@manuroe manuroe mentioned this issue Jan 27, 2020
Closed
@bmarty bmarty self-assigned this Jan 28, 2020
@bmarty bmarty added this to the Sprint9 milestone Jan 28, 2020
This was referenced Jan 28, 2020
Merged
Closed
bmarty added a commit that referenced this issue Jan 29, 2020
@bmarty
Negotiate E2E by default for DMs (#907)
ae36846
@bmarty bmarty mentioned this issue Jan 29, 2020
Merged
bmarty added a commit that referenced this issue Jan 29, 2020
@bmarty
Merge pull request #916 from vector-im/debug_qr
c4649a5 
Negotiate E2E by default for DMs (#907)
@bmarty
Copy link
Member

bmarty commented Jan 30, 2020

Done in #916

@bmarty bmarty closed this as completed Jan 30, 2020
@jryans jryans added the phase:1 label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
None yet
Projects
None yet
Milestone
Sprint9
Development

No branches or pull requests
3 participants
@jryans @bmarty @manuroe