Hide "X made no changes" event by default in timeline (#1430) #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganfra
reviewed
Jun 2, 2020
...android/src/main/java/im/vector/matrix/android/api/session/room/timeline/TimelineSettings.kt
Show resolved
Hide resolved
ganfra
reviewed
Jun 2, 2020
| @@ -38,6 +39,7 @@ internal object EventMapper { | |||
| eventEntity.content = ContentMapper.map(event.content) | |||
| val resolvedPrevContent = event.prevContent ?: event.unsignedData?.prevContent | |||
| eventEntity.prevContent = ContentMapper.map(resolvedPrevContent) | |||
| eventEntity.isUseless = event.type == EventType.STATE_ROOM_MEMBER && eventEntity.content == eventEntity.prevContent | |||
There was a problem hiding this comment.
I don't think it should be saved in db?
There was a problem hiding this comment.
It's saved in DB to be able to do query on it. Maybe you known a better way to do query which check if two value in the DB are identical?
There was a problem hiding this comment.
Oh, right, thanks to realm for not being flexible enough...
Could you create a class like IsUselessResolver to handle this?
There was a problem hiding this comment.
I thought about it, but, it will call again what is called in the three line above, so for the perf, as we are inserting event in DB here, also from initial sync, I do not know if it's a good idea... What do you think?
ganfra
reviewed
Jun 3, 2020
...android/src/main/java/im/vector/matrix/android/internal/database/mapper/IsUselessResolver.kt
Outdated
Show resolved
Hide resolved
ganfra
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1430
Before PR:
After PR: